<html>
<head><meta charset="utf-8"><title>perf try branch · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html">perf try branch</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204566980"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204566980" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204566980">(Jul 21 2020 at 16:03)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> How hard would it be to setup another "try-like" branch that perf could just push to instead of needing to invoke bors?</p>
<p>In particular, we're looking at building artifacts for (some) of the "parts" of a roll-up basically -- I'm wondering what the best way to do that is. So far I have perf creating a PR like this: <a href="https://github.com/rust-lang/rust/pull/74592">https://github.com/rust-lang/rust/pull/74592</a> but that's rather noisy</p>



<a name="204567060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204567060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204567060">(Jul 21 2020 at 16:04)</a>:</h4>
<p>My thought was that we could plausibly just have perf push to some rust-lang/rust branch (or maybe even on a separate repository) or even build on the perf collector</p>



<a name="204567166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204567166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204567166">(Jul 21 2020 at 16:04)</a>:</h4>
<p>but I'm interested in hearing your thoughts on whether this is the right approach or what</p>



<a name="204567467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204567467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204567467">(Jul 21 2020 at 16:06)</a>:</h4>
<p>I'll reply when I get back home</p>



<a name="204567610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204567610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204567610">(Jul 21 2020 at 16:07)</a>:</h4>
<p>Okay!</p>
<p>I'd really rather not build rustc on the collector since it seems really easy for that to diverge from what we do in CI. OTOH, it's also pretty resistant to "CI broke and was fixed since the rollup landed, so you can't base yourself off of that old master"</p>



<a name="204567756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204567756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204567756">(Jul 21 2020 at 16:08)</a>:</h4>
<p>Maybe we have enough capacity also to just do this on all rollups automatically or something, I don't know. That would obviously be ideal.</p>
<p>I suspect we don't have capacity for -- say -- 10 additional builders (if we capped rollups to 10 PRs)</p>



<a name="204568256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204568256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204568256">(Jul 21 2020 at 16:12)</a>:</h4>
<p>and even if we did this is obviously not a good use for them :)</p>



<a name="204571361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571361">(Jul 21 2020 at 16:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> to generate artifacts for intermediate PRs in a rollup, couldn't the merge commits just be pushed to the <code>try</code> branch?</p>



<a name="204571388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571388">(Jul 21 2020 at 16:39)</a>:</h4>
<p>I'm not clear on that, but it's quite possible, yeah</p>



<a name="204571389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571389">(Jul 21 2020 at 16:39)</a>:</h4>
<p>e.g. just pick any PR's merge, push that commit, and you've got a the tree up to that point to get artifacts for</p>



<a name="204571469"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571469" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571469">(Jul 21 2020 at 16:40)</a>:</h4>
<p>you could individually push each merge in a rollu pto <code>try</code> to get perf data for every single commit</p>



<a name="204571474"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571474" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571474">(Jul 21 2020 at 16:40)</a>:</h4>
<p>(e.g., do we need to wait for like 60 seconds or something?)</p>



<a name="204571489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571489">(Jul 21 2020 at 16:40)</a>:</h4>
<p>so that CI can get started</p>



<a name="204571509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571509">(Jul 21 2020 at 16:40)</a>:</h4>
<p>well there's that issue, but the fix for that is probably "not just one <code>try</code> brnach"</p>



<a name="204571514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571514">(Jul 21 2020 at 16:40)</a>:</h4>
<p>but like <code>try-$sha</code></p>



<a name="204571526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571526">(Jul 21 2020 at 16:40)</a>:</h4>
<p>and pattern match that in the CI config</p>



<a name="204571532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571532">(Jul 21 2020 at 16:40)</a>:</h4>
<p>deleting branches after CI is done</p>



<a name="204571539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571539">(Jul 21 2020 at 16:40)</a>:</h4>
<p>yeah so I definitely think this is probably better</p>



<a name="204571572"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571572" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571572">(Jul 21 2020 at 16:41)</a>:</h4>
<p>I guess we'd need to think about whether we have CI capacity for randomly spawning 10 try builds or whatever</p>



<a name="204571596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571596">(Jul 21 2020 at 16:41)</a>:</h4>
<p>(not that that can't happen today w/o this, just gets worse if we add this)</p>



<a name="204571853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571853">(Jul 21 2020 at 16:43)</a>:</h4>
<p>if it's fine to wait for a bit you could do bisection on rollups</p>



<a name="204571908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204571908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204571908">(Jul 21 2020 at 16:44)</a>:</h4>
<p>where you produce artifacts/perf for the middle PR, then depending on that you go left or right</p>



<a name="204573753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204573753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204573753">(Jul 21 2020 at 16:59)</a>:</h4>
<p>Yeah we can usually narrow things down to 2-4 candidates so we can make it manual for now. I'm guessing it's not going to be too hard to make it work, maybe just one more branch for perf-try or something and perf can serialize things as needed.</p>



<a name="204574944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204574944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204574944">(Jul 21 2020 at 17:09)</a>:</h4>
<p>We'll see what Pietro says when he gets back but I'm liking the idea of a dedicated branch. Should make it easier for a number of things in the end I think if we go with this</p>



<a name="204583325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583325">(Jul 21 2020 at 18:19)</a>:</h4>
<blockquote>
<p>I guess we'd need to think about whether we have CI capacity for randomly spawning 10 try builds or whatever</p>
</blockquote>
<p>yeah my main worry would be CI</p>



<a name="204583396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583396">(Jul 21 2020 at 18:19)</a>:</h4>
<p>it is worth noting that a try build on GHA is ~35 minutes and could be cut down to a bit less</p>



<a name="204583458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583458">(Jul 21 2020 at 18:20)</a>:</h4>
<p>so perf would be totally fine with something like "at most one builder running"</p>



<a name="204583519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583519">(Jul 21 2020 at 18:20)</a>:</h4>
<p>hmm so</p>



<a name="204583520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583520">(Jul 21 2020 at 18:20)</a>:</h4>
<p>really this would then be <em>better</em> than just someone opening a PR every half hour in terms of capacity used</p>



<a name="204583554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583554">(Jul 21 2020 at 18:21)</a>:</h4>
<p>it's better than opening PRs because we don't do PR builds</p>



<a name="204583586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583586">(Jul 21 2020 at 18:21)</a>:</h4>
<p>uh what?</p>



<a name="204583611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583611">(Jul 21 2020 at 18:21)</a>:</h4>
<p>oh I see</p>



<a name="204583625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583625">(Jul 21 2020 at 18:21)</a>:</h4>
<p>yeah for sure</p>



<a name="204583628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583628">(Jul 21 2020 at 18:21)</a>:</h4>
<p>like, if you open a PR in addition to the try build you also do the PR build</p>



<a name="204583666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583666">(Jul 21 2020 at 18:22)</a>:</h4>
<p>I mean that try builds are <em>super cheap</em> from a CI time perspective on gha</p>



<a name="204583699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583699">(Jul 21 2020 at 18:22)</a>:</h4>
<p>so the main limiting factor we're going to have is capacity on the XL builders</p>



<a name="204583757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583757">(Jul 21 2020 at 18:22)</a>:</h4>
<p>in the sense that we're never going to block something on auto from landing because perf is running these</p>



<a name="204583776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583776">(Jul 21 2020 at 18:22)</a>:</h4>
<p>I'm not aware of the exact size of that pool since ed is not sure either, but I think it's ~60</p>



<a name="204583783"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583783" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583783">(Jul 21 2020 at 18:22)</a>:</h4>
<p>(or at least it would be really hard)</p>



<a name="204583810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583810">(Jul 21 2020 at 18:22)</a>:</h4>
<p>and we're running auto, try and PR builds all inside that pool</p>



<a name="204583828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583828">(Jul 21 2020 at 18:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> what about doing those perf builds on a 2-core VM instead of 8?</p>



<a name="204583862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583862">(Jul 21 2020 at 18:23)</a>:</h4>
<p>I mean, probably fine? Could have effects on the artifacts produced so I'd rather match exactly what master does</p>



<a name="204583874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583874">(Jul 21 2020 at 18:23)</a>:</h4>
<p>but tbh I'm not really seeing the problem with perf doing this</p>



<a name="204583902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204583902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204583902">(Jul 21 2020 at 18:23)</a>:</h4>
<p>(where this is a single builder at a time being used by perf and not 24/7 either)</p>



<a name="204584037"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584037" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584037">(Jul 21 2020 at 18:24)</a>:</h4>
<p>if we ever run into problems we can talk again, but I'd imagine moving PR builds first is the right step not perf builds</p>



<a name="204584107"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584107" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584107">(Jul 21 2020 at 18:25)</a>:</h4>
<p>hmm I'm not exactly sure -- getting fast feedback for PRs is I think more valuable for contributors</p>



<a name="204584138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584138">(Jul 21 2020 at 18:25)</a>:</h4>
<p>but I see that doing PR builds on XL makes our usage less predictable</p>



<a name="204584251"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584251" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584251">(Jul 21 2020 at 18:26)</a>:</h4>
<p>Basically I think that as things stand right now we should be able to afford this builder for perf</p>



<a name="204584266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584266">(Jul 21 2020 at 18:26)</a>:</h4>
<p>if we're ever in a position where, say, perf needs to check capacity before spawning it, we can do that</p>



<a name="204584280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584280">(Jul 21 2020 at 18:26)</a>:</h4>
<p>(or migrate to a 2-core VM or w/e)</p>



<a name="204584313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584313">(Jul 21 2020 at 18:27)</a>:</h4>
<p>hmm if it's just a single builder I guess ok</p>



<a name="204584497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584497">(Jul 21 2020 at 18:28)</a>:</h4>
<p>can you elaborate on what is concerning about this to you? like, to me it feels like this is far less important than our PR builders in terms of capacity utilization, and generally just "no problem" at all</p>



<a name="204584753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584753">(Jul 21 2020 at 18:30)</a>:</h4>
<p>yeah I guess once we get the concurrency increase is probably going to be fine</p>



<a name="204584780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204584780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204584780">(Jul 21 2020 at 18:30)</a>:</h4>
<p>I'm a bit sad there is no dashboard for the queue nor stats on it</p>



<a name="204585068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204585068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204585068">(Jul 21 2020 at 18:33)</a>:</h4>
<p>okay then I will try and file a PR that adds CI config just on GHA for this</p>



<a name="204585078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204585078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204585078">(Jul 21 2020 at 18:33)</a>:</h4>
<p>(perf-try branch)</p>



<a name="204585732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204585732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204585732">(Jul 21 2020 at 18:38)</a>:</h4>
<p>remember that the commit will have to be pushed on rust-lang-ci</p>



<a name="204585849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204585849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204585849">(Jul 21 2020 at 18:39)</a>:</h4>
<p>hm so we don't need a try branch on rust-lang/rust at all?</p>



<a name="204587052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204587052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204587052">(Jul 21 2020 at 18:49)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> </p>
<p>So rust-timer will need to:</p>
<ul>
<li>push a commit to perf-try branch on rust-lang-ci/rust  which will automatically trigger GHA</li>
<li>wait for GHA to finish</li>
<li>enqueue another build on perf-try (if any)</li>
</ul>
<p>async:</p>
<p>* run perf on built artifacts</p>



<a name="204587075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204587075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204587075">(Jul 21 2020 at 18:49)</a>:</h4>
<p>yeah</p>



<a name="204587185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204587185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204587185">(Jul 21 2020 at 18:50)</a>:</h4>
<p>okay great</p>



<a name="204587220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204587220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204587220">(Jul 21 2020 at 18:50)</a>:</h4>
<p>Do you want a dedicate try config for this branch or is it fine to edit the existing one to run on either branch?</p>



<a name="204587234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204587234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204587234">(Jul 21 2020 at 18:50)</a>:</h4>
<p>I guess less maintenance if we keep the same config</p>



<a name="204591270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204591270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204591270">(Jul 21 2020 at 19:22)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I don't care either way :)</p>



<a name="204591297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204591297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204591297">(Jul 21 2020 at 19:23)</a>:</h4>
<p>okay I opened a PR and r?'d you on it</p>



<a name="204591342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204591342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204591342">(Jul 21 2020 at 19:23)</a>:</h4>
<p>though looks like highfive didn't notice that? anyway <a href="https://github.com/rust-lang/rust/pull/74600">https://github.com/rust-lang/rust/pull/74600</a></p>



<a name="204591833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204591833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204591833">(Jul 21 2020 at 19:27)</a>:</h4>
<p>I'll take a look tomorrow</p>



<a name="204594097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/perf%20try%20branch/near/204594097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/perf.20try.20branch.html#204594097">(Jul 21 2020 at 19:43)</a>:</h4>
<p>Thanks!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>